[SecurityBundle] Deprecate not configuring explicitly a provider for custom_authenticators when there is more than one registered provider #43835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Oct 29, 2021
lyrixx
commented
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | yes |
| Tickets | |
| License | MIT |
| Doc PR | not needed I guess |
…custom_authenticators when there is more than one registered provider
Member
|
Thank you @lyrixx. |
Member
|
This deprecation is apparently causing our CI to fail on 5.4 because it's triggered in a SecurityBundle test: https://github.com/symfony/symfony/runs/4055121217?check_suite_focus=true#step:8:853 Can you take a look, @lyrixx? |
fabpot
added a commit
that referenced
this pull request
Oct 31, 2021
This PR was merged into the 5.4 branch. Discussion ---------- [SecurityBundle] Fix tests | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | - | New feature? | - | Deprecations? | - | Tickets | - | License | MIT | Doc PR | - We missed flagging this test as legacy in #43835. Commits ------- 69f12ef [SecurityBundle] Fix tests
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.