[Dotenv] Fix testLoadEnv() to start from a fresh context #43692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
force-pushed
the
dotenv/fix-test
branch
from
4d08c07 to
ed70b78
Compare
nicolas-grekas
approved these changes
Oct 25, 2021
Member
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 26, 2021
… (fancyweb) This PR was merged into the 5.3 branch. Discussion ---------- [Dotenv] Fix testBootEnv() to start from a fresh context | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Same reason than #43692, needed by #43755. Commits ------- 417b9c2 [Dotenv] Fix testBootEnv() to start from a fresh context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code doesn't test properly because
SYMFONY_DOTENV_VARSstate is not cleaned for example. We want to test "from the start" everytime here (with no state from a previous load, like it would be in a real app).