[BrowserKit][HttpClient][Routing] support building query strings with stringables #43612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
requested review from
OskarStark,
chalasr and
wouterj
as code owners
nicolas-grekas
force-pushed
the
build-query
branch
from
2a38fad to
c54302b
Compare
nicolas-grekas
force-pushed
the
build-query
branch
from
c54302b to
65e2cac
Compare
Member
|
Just asking: would replacing |
Member
Author
|
Those arrays are pretty small, any impact should be neglectible. |
Member
Author
|
/cc @symfony/mergers |
OskarStark
approved these changes
Oct 26, 2021
Contributor
|
Thanks for taking over Nicolas 👍 |
Tobion
approved these changes
Oct 26, 2021
Contributor
|
Thank you @nicolas-grekas. |
Contributor
|
Also thank you @OskarStark |
lyrixx
reviewed
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows using eg an instance of
Uidas a route parameter.Replaces #42057