[Security] Move TraceableAuthenticator to security-http
#43401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
mv-trace-auth
branch
4 times, most recently
from
6e02bd0 to
55104c2
Compare
chalasr
force-pushed
the
mv-trace-auth
branch
from
55104c2 to
876222f
Compare
derrabus
approved these changes
Oct 12, 2021
fabpot
approved these changes
Oct 12, 2021
Member
|
Thank you @chalasr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary to fix tests on branch 6.0 https://github.com/symfony/symfony/runs/3861906767.
There is an incompatible signature for
AuthenticatorInterface::createAuthenticatedToken()between security-bundle 6.0 and security-http 5.4 because of the deprecatedPassportInterfacetype.Moving
TraceableAuthenticatorandTraceableAuthenticatorManagerListenertosecurity-httpfixes the issue and it's looking good to me.