[HttpKernel] Fix incorrect invalid message and change range to compare #43399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahummeling
reviewed
Oct 11, 2021
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
Contributor
|
Additionally, seems like 1 of the tests is failing. Perhaps there's a testcase that explicitly asserts the messages are equal, this expected message should be updated as well. |
lyrixx
approved these changes
Oct 12, 2021
[HttpKernel] Allow all http status codes and change invalid message
JohJohan
force-pushed
the
improve-check-and-message
branch
from
359fe84 to
e5a7f83
Compare
fabpot
approved these changes
Oct 13, 2021
Member
|
Thank you @JohJohan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix invlid config message and change range to two comparisons
#42244 (comment)