Do not use str_starts_with in translation-status.php #42533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are not loading polyfill here so str_starts_with is not available PHP <8.0
hluup
changed the title
hluup
changed the title
hluup
changed the title
fabpot
approved these changes
Aug 13, 2021
carsonbot
changed the title
Member
|
Thank you @hluup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translation-status.phpis a standalone script that might be run with PHP version that is less than <8.0 wherestr_starts_withis not available. I propose that we revert the change that was made in #41576 instead of trying to load the polyfill somehow.