[Messenger] [Redis] Remove BC layer around delete_after_ack option
#42245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Jul 23, 2021
chalasr
commented
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
carsonbot
changed the title
delete_after_ack optiondelete_after_ack option
chalasr
commented
Jul 23, 2021
| trigger_deprecation('symfony/messenger', '5.3', 'The method "%s()" is deprecated, use getGlobalFailureReceiverName() instead.', __METHOD__); | ||
|
|
||
| return $this->globalFailureReceiverName; | ||
| } |
Member
Author
There was a problem hiding this comment.
unrelated change, but makes the bridge deprec-free. The class is internal so no need for a changelog entry (we didn't even add one when deprecating)
Member
Author
|
fabbot is wrong (still struggles with union types) - PR ready |
OskarStark
approved these changes
Jul 24, 2021
Member
|
Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.