Skip to content

Conversation

@a1812
Copy link
Contributor

@a1812 a1812 commented Jul 22, 2021

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR

I think that in tests we need to adhere to one style, if we skip tests with "stty", then this one needs to be skipped or unchecked from all the others.

C:\symfony>C:\php\7.1.3\php.exe C:\symfony\phpunit --color=never --bootstrap C:\symfony\vendor\autoload.php --configuration C:\symfony\phpunit.xml.dist src/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php
#!/usr/bin/env php
PHPUnit 7.5.20 by Sebastian Bergmann and contributors.

Testing Symfony\Component\Console\Tests\Helper\QuestionHelperTest
....SSSSSSSSSSSS..................................SSF             53 / 53 (100%)

Time: 912 ms, Memory: 8.00 MB

There was 1 failure:

1) Symfony\Component\Console\Tests\Helper\QuestionHelperTest::testTraversableMultiselectAutocomplete
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'FooBundle'
+    0 => 'AcmeDemoBundle'
+    1 => 'AsseticBundle'
 )

C:\symfony\src\Symfony\Component\Console\Tests\Helper\QuestionHelperTest.php:864

FAILURES!
Tests: 53, Assertions: 72, Failures: 1, Skipped: 14.
`

@a1812 a1812 requested a review from chalasr as a code owner July 22, 2021 17:13
@carsonbot carsonbot added this to the 4.4 milestone Jul 22, 2021
@fabpot
Copy link
Member

fabpot commented Jul 25, 2021

Thank you @a1812.

@fabpot fabpot merged commit 38bbe02 into symfony:4.4 Jul 25, 2021
@a1812 a1812 deleted the fix_test_for_windows branch October 6, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants