[Finder] Add types to private properties #42106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
derrabus
commented
Jul 14, 2021
derrabus
commented
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | no |
| New feature? | n0 |
| Deprecations? | n0 |
| Tickets | N/A |
| License | MIT |
| Doc PR | N/A |
derrabus
force-pushed
the
types/finder-properties
branch
from
8d2ea6d to
3232c9f
Compare
|
Hey! I think @hurricane-voronin has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
stof
reviewed
Jul 15, 2021
| { | ||
| private $target; | ||
| private $operator = '=='; | ||
| private ?string $target = null; |
Member
There was a problem hiding this comment.
the type of the getter probably needs to be updated (or this should default to the empty string).
Member
Author
There was a problem hiding this comment.
Calling the getter before initialization does not really make sense. The two child classes of Comparator do initialize the property via the constructor. Let's skip the initialization.
Member
Author
There was a problem hiding this comment.
Let's make that class a bit more robust: #42137
derrabus
force-pushed
the
types/finder-properties
branch
from
3232c9f to
2a4b756
Compare
Signed-off-by: Alexander M. Turek <me@derrabus.de>
derrabus
force-pushed
the
types/finder-properties
branch
from
2a4b756 to
33f8a66
Compare
Tobion
approved these changes
Jul 17, 2021
Contributor
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.