Skip to content

[Notifier] [Slack] Throw error if maximum block limit is reached for slack message options #42094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
derrabus merged 1 commit into from
Jul 15, 2021
Merged

[Notifier] [Slack] Throw error if maximum block limit is reached for slack message options #42094

derrabus merged 1 commit into from
Jul 15, 2021

Conversation

@norkunas
Copy link
Contributor

@norkunas norkunas commented Jul 14, 2021

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets #42090 (comment)
License MIT
Doc PR N/A

As requested to improve DX :)

@norkunas norkunas requested a review from OskarStark as a code owner July 14, 2021 03:32
@norkunas norkunas force-pushed the slack-blocks-limit branch from 4adb17d to 2731aae Compare July 14, 2021 03:36
@OskarStark OskarStark added DX DX = Developer eXperience (anything that improves the experience of using Symfony) and removed Status: Reviewed labels Jul 14, 2021
@OskarStark OskarStark added this to the 5.4 milestone Jul 14, 2021
@OskarStark OskarStark requested a review from jderusse July 14, 2021 05:32
OskarStark
OskarStark reviewed Jul 14, 2021
View reviewed changes
@norkunas norkunas force-pushed the slack-blocks-limit branch from 2731aae to 4647f9c Compare July 14, 2021 06:13
OskarStark
OskarStark approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick response 👍

jderusse
jderusse reviewed Jul 14, 2021
View reviewed changes
@norkunas norkunas force-pushed the slack-blocks-limit branch from 4647f9c to db5e308 Compare July 14, 2021 08:44
@norkunas norkunas force-pushed the slack-blocks-limit branch from db5e308 to 4faa677 Compare July 14, 2021 11:29
@derrabus
Copy link
Member

derrabus commented Jul 15, 2021

Thank you @norkunas.

@derrabus derrabus mentioned this pull request Jul 15, 2021
Closed
@derrabus derrabus merged commit 5d92b21 into symfony:5.4 Jul 15, 2021
@norkunas norkunas deleted the slack-blocks-limit branch July 15, 2021 03:24
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jderusse jderusse jderusse approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees

No one assigned

Labels

DX DX = Developer eXperience (anything that improves the experience of using Symfony) Feature Notifier Status: Reviewed

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@norkunas @derrabus @jderusse @OskarStark @carsonbot