[Security] Fix special char used to create cache key #41737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Security/Core/Authentication/RememberMe/CacheTokenVerifier.php
Outdated
Show resolved
Hide resolved
noniagriconomie
approved these changes
Jun 18, 2021
chalasr
approved these changes
Jun 18, 2021
wouterj
requested changes
Jun 18, 2021
Member
wouterj
left a comment
wouterj
left a comment
There was a problem hiding this comment.
Travis failures are related to the changes afaics
src/Symfony/Component/Security/Core/Authentication/RememberMe/CacheTokenVerifier.php
Outdated
Show resolved
Hide resolved
javiereguiluz
approved these changes
Jun 23, 2021
Member
|
Thanks Jérémy. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remember Me token's
seriesproperty might contains special chars: because it has been generated with$series = base64_encode(random_bytes(64));.When using this identifier to create cache items, users get Exception
Cache key "foo+bar/baz==" contains reserved characters "{}()/\@:".This PR sanitize the property before using it as cache key