Add union types #41424
Closed
Add union types #41424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
requested review from
chalasr,
dunglas,
lyrixx,
sroze,
wouterj,
xabbuh and
yceruto
as code owners
Warxcell
reviewed
May 27, 2021
Contributor
|
just minor consistency some union definitions have spaces around the pipe character, but some don't |
Contributor
|
is there a CS rule? |
wouterj
reviewed
May 27, 2021
Member
wouterj
left a comment
wouterj
left a comment
There was a problem hiding this comment.
Fyi, I've reviewed up to the Console component.
This PR does not only introduce union types, but also some object, string and bool types. Is that intended?
| * @return array|null Array with important QueryBuilder parts or null if | ||
| * they can't be determined | ||
| * | ||
| * @internal This method is public to be usable as callback. It should not |
Member
There was a problem hiding this comment.
Unrelated, but this one, the one above and the one in EntityType below can also be made private in Symfony 5.4 I think. The required public visibility is from 6 years ago, when $this inside a closure was not yet supported (3172d73).
Member
Author
There was a problem hiding this comment.
correct, anyone up for a PR doing so?
Member
Author
|
Thank you all and @wouterj especially for the review. This is going to take ages to get right. The more eyes the better :) |
nicolas-grekas
force-pushed
the
unions
branch
3 times, most recently
from
fab0860 to
141fdec
Compare
nicolas-grekas
added a commit
that referenced
this pull request
May 28, 2021
This PR was merged into the 6.0 branch. Discussion ---------- [Yaml] add types to all arguments | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Extracted from #41424 Commits ------- 129411e [Yaml] add types to all arguments
nicolas-grekas
added a commit
that referenced
this pull request
May 28, 2021
This PR was merged into the 6.0 branch. Discussion ---------- [Workflow] add types to all arguments | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Extracted from #41424 Commits ------- 6a94b77 [Workflow] add types to all arguments
nicolas-grekas
added a commit
that referenced
this pull request
May 28, 2021
This PR was merged into the 6.0 branch. Discussion ---------- [VarDumper] add types to all arguments | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Extracted from #41424 Commits ------- e68b368 [VarDumper] add types to all arguments
nicolas-grekas
added a commit
that referenced
this pull request
Jun 29, 2021
This PR was merged into the 6.0 branch. Discussion ---------- [Config] Add parameter types | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Part of #41424 | License | MIT | Doc PR | N/A This PR adds parameter types to all methods of the Config component. Commits ------- e7e5256 [Config] Add parameter types
nicolas-grekas
added a commit
that referenced
this pull request
Jun 29, 2021
This PR was merged into the 6.0 branch. Discussion ---------- [DependencyInjection] add union types | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Part of #41424 | License | MIT | Doc PR | - Commits ------- e017977 [DependencyInjection] add union types
This was referenced Jun 29, 2021
nicolas-grekas
added a commit
that referenced
this pull request
Jun 30, 2021
This PR was merged into the 6.0 branch. Discussion ---------- [HttpFoundation] add union types | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Part of #41424 | License | MIT | Doc PR | - Commits ------- 9f4a5fb [HttpFoundation] add union types
nicolas-grekas
force-pushed
the
unions
branch
3 times, most recently
from
d4dc8b1 to
fc6fa3a
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jul 1, 2021
This PR was merged into the 6.0 branch. Discussion ---------- [FrameworkBundle] add union types | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Part of #41424 | License | MIT | Doc PR | - Commits ------- e85e459 [FrameworkBundle] add union types
nicolas-grekas
added a commit
that referenced
this pull request
Jul 1, 2021
This PR was merged into the 6.0 branch. Discussion ---------- [Serializer] add union types | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Part of #41424 | License | MIT | Doc PR | - Commits ------- 4db6d56 [Serializer] add union types
Member
Author
|
Closing as the only remaining changes are for Cache, and there is already #41290. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 7, 2021
This PR was merged into the 6.0 branch. Discussion ---------- [Cache] Leverage union types | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Part of #41424 | License | MIT | Doc PR | - Commits ------- 3275859 [Cache] Leverage union types
nicolas-grekas
added a commit
that referenced
this pull request
Jul 7, 2021
This PR was squashed before being merged into the 6.0 branch. Discussion ---------- [Form] add union types | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Part of #41424 | License | MIT | Doc PR | - Commits ------- 0480be6 [Form] add union types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created using https://github.com/rectorphp/rector/ and manual editing (a lot of them. ;))
For the record, I'm using this command to inspect a specific component:
grep -l 'function [a-zA-Z_].*(\([$]\|.*, [$]\)' -- $(find src/Symfony/Component/Messenger -type f|grep Tests -v)