Skip to content

[Mime] Removes tests for code that has been deleted #41398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0x346e3730 wants to merge 3 commits into from
Closed

[Mime] Removes tests for code that has been deleted #41398

0x346e3730 wants to merge 3 commits into from

Conversation

@0x346e3730
Copy link
Contributor

@0x346e3730 0x346e3730 commented May 24, 2021

Q A
Branch? 6.0
Bug fix? yes
New feature? no
Deprecations? no
Tickets None
License MIT
Doc PR Not a new feature

This PR fixes tests on the MIME component after a deprecated method was removed on the 6.0 branch by the PR #41364

@carsonbot carsonbot added this to the 6.0 milestone May 24, 2021
@carsonbot
Copy link

carsonbot commented May 24, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

nicolas-grekas commented May 24, 2021

This should be applied on 5.2, I think, as the code in 5.2 should not call any deprecated codepath.

@nicolas-grekas
Copy link
Member

nicolas-grekas commented May 24, 2021

Oh wait, no! The tests cases should be remove instead, that's why they're marked as group legacy.!

@nicolas-grekas nicolas-grekas mentioned this pull request May 24, 2021
Merged
@0x346e3730
Copy link
Contributor Author

0x346e3730 commented May 24, 2021

I'll update asap to remove the tests, nice catch

@0x346e3730 0x346e3730 force-pushed the fix-mime-tests-sf6 branch from d6f9fea to 3d00017 Compare May 24, 2021 21:16
@0x346e3730 0x346e3730 changed the title [Mime] Fixes tests for the MIME component [Mime] Removes tests for code that has been deleted May 24, 2021
@0x346e3730 0x346e3730 mentioned this pull request May 24, 2021
Merged
@0x346e3730
Copy link
Contributor Author

0x346e3730 commented May 24, 2021

Closing in favor of #41404.

@0x346e3730 0x346e3730 closed this May 24, 2021
Nyholm added a commit that referenced this pull request May 25, 2021
@Nyholm
minor #41404 [Mime] Removes deprecated tests (0x346e3730)
8885c2d 
This PR was merged into the 6.0 branch.

Discussion
----------

[Mime] Removes deprecated tests

| Q             | A
| ------------- | ---
| Branch?       | 6.0
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Follow-up from #41398 to fix CI for 6.0.

Commits
-------

cc358f4 [Mime] Removes deprecated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug Mime Status: Needs Review

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@0x346e3730 @carsonbot @nicolas-grekas