[PropertyAccess] Remove deprecated code #41365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @HeahDude has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
jschaedl
reviewed
May 23, 2021
| */ | ||
| public function testGetValueReturnsNullIfPropertyNotFoundAndExceptionIsDisabledUsingBooleanArgument($objectOrArray, $path) | ||
| { | ||
| $this->expectDeprecation('Since symfony/property-access 5.3: Passing a boolean as the fourth argument to "Symfony\Component\PropertyAccess\PropertyAccessor::__construct()" is deprecated. Pass a combination of bitwise flags as the second argument instead (i.e an integer).'); |
Contributor
There was a problem hiding this comment.
Please also remove ExpectDeprecationTrait from this test:
see #41298 (comment)
jschaedl
reviewed
May 23, 2021
| public function __construct(int $magicMethods = self::MAGIC_GET | self::MAGIC_SET, int $throw = self::THROW_ON_INVALID_PROPERTY_PATH, CacheItemPoolInterface $cacheItemPool = null, PropertyReadInfoExtractorInterface $readInfoExtractor = null, PropertyWriteInfoExtractorInterface $writeInfoExtractor = null) | ||
| { | ||
| if (\is_bool($magicMethods)) { | ||
| trigger_deprecation('symfony/property-access', '5.2', 'Passing a boolean as the first argument to "%s()" is deprecated. Pass a combination of bitwise flags instead (i.e an integer).', __METHOD__); |
Contributor
There was a problem hiding this comment.
You can remove symfony/deprecation-contracts from the composer.json file. See #41298 (comment)
Contributor
|
Shall we update the component's CHANGELOG file accordingly? |
Member
yes please, please also rebase and take review comments into account of course |
Member
|
Please rebase to restart tests 🙏 |
Member
|
Thank you @malteschlueter. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove deprecated code from PropertyAccess.