[Intl] Add missing entries to intl upgrade log #41362
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Member
|
All these classes are internal AFAIK. If confirmed, there is no need for these lines. |
Contributor
Author
Good to know, thank you^^ Only the deleted Exceptions are not |
stof
reviewed
May 22, 2021
| Intl | ||
| ---------- | ||
|
|
||
| * Deprecate `DateFormatter` namespace, use symfony/polyfill-intl-icu ^1.21 instead |
Member
There was a problem hiding this comment.
These are internal classes. What should be mentioned are the polyfill classes for PHP class names
Contributor
Author
|
Okay, I will close this PR. Thank you @nicolas-grekas and @stof |
Member
|
There is still a need to mention that the polyfills bundled in the component are deprecated, and that you shuld install the polyfill package if you rely on them. |
Member
|
for the exception, the |
nicolas-grekas
added a commit
that referenced
this pull request
May 27, 2021
This PR was merged into the 6.0 branch. Discussion ---------- [Intl] Removed deprecated code | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This remove deprecated code from Intl. TODO - [x] Update UPGRADE-5.3.md and UPGRADE-6.0.md in Branch 5.3 #41362 Commits ------- 87f785b [Intl] Removed deprecated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #41361.