Skip to content

Conversation

@franmomu
Copy link
Contributor

@franmomu franmomu commented May 1, 2021

Q A
Branch? 5.x
Bug fix? no (there is not release yet)
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

There shouldn't be blank spaces between the arguments of the GithubActionReporter, otherwise it shows the message in the wrong line, it can be seen here: https://github.com/franmomu/test_yaml_lint/pull/3/files

Both messages are supposed to be for line 3, but the warning one (with blank spaces) appears on line 1 (Check warning on line 1 in wrong_yaml.yaml).

Blank spaces between the arguments of the GithubActionReporter
messages make them appear always on line 1.
@fabpot
Copy link
Member

fabpot commented May 1, 2021

Thank you @franmomu.

@fabpot fabpot merged commit e46d964 into symfony:5.x May 1, 2021
@fabpot fabpot mentioned this pull request May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants