[CI] Sort packages by length to match modified package better #40928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Apr 23, 2021
welcoMattic
approved these changes
Apr 23, 2021
4 tasks
OskarStark
approved these changes
Apr 27, 2021
welcoMattic
approved these changes
Apr 27, 2021
stof
approved these changes
Apr 27, 2021
Member
Author
|
PR is rebased and squashed |
Contributor
|
Thanks Tobias. |
Member
Author
|
Lovely. Thank you for merging =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the build error in #40927, I saw that we match "modified packages" wrong. The script things we modified
symfony/translationrather than the new bridge. This is because we are using a simple string matchning. If we sort the packages by length, we make sure we match the most detailed (longest) string first.