[Translation] Added PoEditor Provider #40926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that you need squash your commits before this PR can be merged. The maintainer can also squash the commits for you, but then you need to “Allow edits from maintainer” (there is a checkbox in the sidebar of the PR). Cheers! Carsonbot |
welcoMattic
force-pushed
the
feature/poeditor-provider
branch
4 times, most recently
from
363ff30 to
3fbeb16
Compare
stof
reviewed
Apr 26, 2021
src/Symfony/Component/Translation/Bridge/PoEditor/Provider/PoEditorProvider.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Translation/Bridge/PoEditor/Provider/PoEditorProvider.php
Outdated
Show resolved
Hide resolved
welcoMattic
force-pushed
the
feature/poeditor-provider
branch
2 times, most recently
from
cd050d5 to
0ab9d41
Compare
Member
Author
|
Package / Verify check fails now, it will be fixed as soon as #40928 will be merged. |
welcoMattic
force-pushed
the
feature/poeditor-provider
branch
4 times, most recently
from
a50035f to
32e25a0
Compare
OskarStark
reviewed
Apr 27, 2021
OskarStark
reviewed
Apr 27, 2021
src/Symfony/Component/Translation/Bridge/PoEditor/PoEditorProviderFactory.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Apr 27, 2021
src/Symfony/Component/Translation/Bridge/PoEditor/composer.json
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Apr 27, 2021
src/Symfony/Component/Translation/Exception/UnsupportedSchemeException.php
Outdated
Show resolved
Hide resolved
welcoMattic
force-pushed
the
feature/poeditor-provider
branch
2 times, most recently
from
4952323 to
63b9b51
Compare
Member
Author
|
It ready for me for a review. |
stof
requested changes
Apr 27, 2021
src/Symfony/Component/Translation/Bridge/PoEditor/PoEditorProvider.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Translation/Bridge/PoEditor/PoEditorProvider.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Translation/Bridge/PoEditor/PoEditorProvider.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Translation/Bridge/PoEditor/PoEditorProvider.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Translation/Bridge/PoEditor/PoEditorProvider.php
Outdated
Show resolved
Hide resolved
welcoMattic
force-pushed
the
feature/poeditor-provider
branch
4 times, most recently
from
700b7f3 to
3d39d82
Compare
welcoMattic
force-pushed
the
feature/poeditor-provider
branch
from
b13f0d4 to
4a199d1
Compare
nicolas-grekas
approved these changes
May 7, 2021
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Show resolved
Hide resolved
welcoMattic
force-pushed
the
feature/poeditor-provider
branch
from
4a199d1 to
25bab11
Compare
welcoMattic
commented
May 7, 2021
src/Symfony/Component/Translation/Bridge/PoEditor/Tests/PoEditorProviderTest.php
Show resolved
Hide resolved
Member
|
Tests seem broken. |
welcoMattic
force-pushed
the
feature/poeditor-provider
branch
from
25bab11 to
7568332
Compare
fabpot
requested changes
May 10, 2021
src/Symfony/Component/Translation/Bridge/PoEditor/PoEditorProviderFactory.php
Outdated
Show resolved
Hide resolved
welcoMattic
force-pushed
the
feature/poeditor-provider
branch
2 times, most recently
from
865cb70 to
3b1c532
Compare
welcoMattic
force-pushed
the
feature/poeditor-provider
branch
from
3b1c532 to
240ac22
Compare
welcoMattic
commented
May 10, 2021
|
|
||
| * Add `translation:pull` and `translation:push` commands to manage translations with third-party providers | ||
| * Add `TranslatorBagInterface::getCatalogues` method | ||
| * Add support to load XLIFF string in `XliffFileLoader` |
Member
Author
There was a problem hiding this comment.
@fabpot I've added those missing changes here
Member
Author
|
Last comments have been addressed, branch has been rebased |
fabpot
approved these changes
May 10, 2021
Member
|
Thank you @welcoMattic. |
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
May 19, 2021
This PR was submitted for the 5.4 branch but it was squashed and merged into the 5.3 branch instead. Discussion ---------- [Translation] Introduce Translation Providers Docs for symfony/symfony#38475, symfony/symfony#40926, symfony/symfony#40927, and symfony/symfony#40947 Ready for first review, but I'm not sure that I've written documentation in the right and all required places. ATM, Translation Providers Bridges packages doesn't exists, so Flex recipes are not created yet. Commits ------- 943a63f [Translation] Introduce Translation Providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow up on #38475, this PR adds PoEditor Provider.
The todo list to make it ready is:
ProviderInterfaceandTranslatorBagInterface(we removed theall()andgetDomains()method from TranslatorBagInterface)src/Symfony/Bundle/FrameworkBundle/Resources/config/translation_providers.phpfileSymfony\Component\Translation\Exception\UnsupportedSchemeExceptionThe major part of the remaining work concerns tests, I will make it done before the beginning of May.