[Cache] Deprecate DoctrineProvider #40908
Conversation
|
cc @alcaeus |
derrabus
force-pushed
the
improvement/deprecate-doctrine-cache-provider
branch
3 times, most recently
from
8b209b9 to
b912136
Compare
alcaeus
left a comment
alcaeus
left a comment
There was a problem hiding this comment.
LGTM, but we can allow cache 2.0, which will be released next week.
| "require-dev": { | ||
| "doctrine/annotations": "^1.10.4", | ||
| "doctrine/cache": "~1.0", | ||
| "doctrine/cache": "^1.11", |
There was a problem hiding this comment.
This can also allow 2.0 as long as you're not using an actual implementation:
| "doctrine/cache": "^1.11", | |
| "doctrine/cache": "^1.11|^2.0", |
| "symfony/translation": "^4.4|^5.0", | ||
| "doctrine/annotations": "^1.10.4", | ||
| "doctrine/cache": "~1.0", | ||
| "doctrine/cache": "^1.11", |
There was a problem hiding this comment.
This needs more changes in the Validator component. Under certain circumstances, we still use an array cache from Doctrine. I'll do this in a follow-up.
derrabus
force-pushed
the
improvement/deprecate-doctrine-cache-provider
branch
from
b912136 to
c4c35d0
Compare
derrabus
force-pushed
the
improvement/deprecate-doctrine-cache-provider
branch
from
c4c35d0 to
5fb1867
Compare
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
I'm also 👍 to add ^2.0, either in this PR or in a follow up one.
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Would it be simpler if we also updated doctrine/annotations at the same time?
| $reader = new PsrCachedReader($this->annotationReader, $arrayAdapter, $this->debug); | ||
| } else { | ||
| $reader = new CachedReader($this->annotationReader, new DoctrineProvider($arrayAdapter), $this->debug); | ||
| $reader = new CachedReader($this->annotationReader, DoctrineProvider::wrap($arrayAdapter), $this->debug); |
There was a problem hiding this comment.
This line can be removed, right? It is dead code if we also update to doctrine/annotations:1.13.
There was a problem hiding this comment.
As soon as we have a stable release of doctrine/annotations 1.13, yes.
There was a problem hiding this comment.
doctrine/annotations 1.13 is not released yet and is not sure to be released before the next 5.x release.
There was a problem hiding this comment.
oops sorry. I read the wrong version on packagist. I though it was released already.
There was a problem hiding this comment.
No worries. I also misread and it looks like this is scheduled for 5.4 anyways, so we can definitely make that change.
derrabus
force-pushed
the
improvement/deprecate-doctrine-cache-provider
branch
from
5fb1867 to
262ac66
Compare
|
I'll update the PR as soon as #41230 is merged and has bubbled up to 5.x. |
derrabus
force-pushed
the
improvement/deprecate-doctrine-cache-provider
branch
from
262ac66 to
0d0b932
Compare
fabpot
force-pushed
the
improvement/deprecate-doctrine-cache-provider
branch
from
0d0b932 to
16fccfa
Compare
|
Thank you @derrabus. |
This PR was merged into the 6.0 branch. Discussion ---------- [Cache] Remove DoctrineProvider | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #40908 | License | MIT | Doc PR | N/A Commits ------- b71101f [Cache] Remove DoctrineProvider
7 participants
The
DoctrineProviderclass has been reimplemented in thedoctrine/cachepackage, so we don't have to maintain it anymore.