[Notifier] Notifier add test for adding transport factories to framework extension #40845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschaedl
changed the title
jschaedl
force-pushed
the
notifier-add-test-add-transport-factory-to-framework-extension
branch
2 times, most recently
from
948a692 to
97378de
Compare
3 tasks
jschaedl
force-pushed
the
notifier-add-test-add-transport-factory-to-framework-extension
branch
from
97378de to
c41e164
Compare
jschaedl
changed the title
jschaedl
changed the title
jschaedl
force-pushed
the
notifier-add-test-add-transport-factory-to-framework-extension
branch
3 times, most recently
from
70e1b6e to
ddf61c2
Compare
Member
|
Can you please merge this with #40844? |
Contributor
|
Oh sorry @nicolas-grekas I already merged #40844 😢 @jschaedl can you please rebase? Thanks |
jschaedl
force-pushed
the
notifier-add-test-add-transport-factory-to-framework-extension
branch
from
ddf61c2 to
1ba324c
Compare
carsonbot
changed the title
nicolas-grekas
approved these changes
Apr 17, 2021
Contributor
|
Can you please check Travis? |
jschaedl
force-pushed
the
notifier-add-test-add-transport-factory-to-framework-extension
branch
2 times, most recently
from
93b1522 to
8b6bbfd
Compare
jschaedl
commented
Apr 17, 2021
jschaedl
commented
Apr 17, 2021
jschaedl
commented
Apr 17, 2021
src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Apr 18, 2021
…rameworkExtension anymore
fabpot
force-pushed
the
notifier-add-test-add-transport-factory-to-framework-extension
branch
from
1e24de5 to
3118c90
Compare
Member
|
Thank you @jschaedl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #40843 and #40844
Needs to be rebased after both were merged.
See changes: ddf61c2