[FrameworkBundle] Add missing notifier transport factories to framework extension #40843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Apr 17, 2021
OskarStark
force-pushed
the
notifier-add-missing-factories-to-frameworkextension
branch
from
9c9c62a to
a83c9fe
Compare
Contributor
|
... and one more bug fixed, thank you Jan. |
3 tasks
fabpot
added a commit
that referenced
this pull request
Apr 18, 2021
…ies to framework extension (jschaedl, fabpot) This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] Notifier add test for adding transport factories to framework extension | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | <!-- required for new features --> Follow up of #40843 and #40844 Needs to be rebased after both were merged. See changes: ddf61c2 Commits ------- 3118c90 Make sure we will not forget to add notifier transport factories to FrameworkExtension anymore
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Apr 18, 2021
…ies to framework extension (jschaedl, fabpot) This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] Notifier add test for adding transport factories to framework extension | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | <!-- required for new features --> Follow up of symfony/symfony#40843 and symfony/symfony#40844 Needs to be rebased after both were merged. See changes: symfony/symfony@ddf61c2 Commits ------- 3118c9088a Make sure we will not forget to add notifier transport factories to FrameworkExtension anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests on #39353 were failing (https://travis-ci.com/github/symfony/symfony/jobs/499236540) because of missing entries in the
$classToServicesarray. They are now added and the list is ordered alphabetically.Missing entries: