[Cache][FrameworkBundle] Fix logging for TagAwareAdapter #40740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fancyweb
commented
Apr 8, 2021
fancyweb
commented
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | #40108 |
| License | MIT |
| Doc PR | - |
carsonbot
changed the title
fancyweb
force-pushed
the
cache-fwb/tag-aware-log
branch
from
cccd9d1 to
22de60a
Compare
Contributor
Author
|
Do we want to bump the required minimum symfony/cache version in FWB for this or add a runtime check? |
|
Hey! I think @v-m-i has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
v-m-i
suggested changes
Apr 9, 2021
Contributor
v-m-i
left a comment
v-m-i
left a comment
There was a problem hiding this comment.
Hi @fancyweb, thank you for this PR.
Kudos for detailed and readable tests.
I have added one typo-fix suggestion. Everything else looks good :)
Besides code, I see that some builds have failed so I would suggest looking into that.
src/Symfony/Component/Cache/Tests/Adapter/TagAwareAdapterTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Apr 9, 2021
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
(once the typo is fixed)
fancyweb
force-pushed
the
cache-fwb/tag-aware-log
branch
9 times, most recently
from
c08849f to
beb338b
Compare
fancyweb
force-pushed
the
cache-fwb/tag-aware-log
branch
from
beb338b to
6b0beca
Compare
fancyweb
commented
Apr 11, 2021
| public static function compute(callable $callback, ItemInterface $item, bool &$save, CacheInterface $pool, \Closure $setMetadata = null, LoggerInterface $logger = null) | ||
| { | ||
| $key = self::$files ? crc32($item->getKey()) % \count(self::$files) : -1; | ||
| $key = self::$files ? abs(crc32($item->getKey())) % \count(self::$files) : -1; |
Contributor
Author
There was a problem hiding this comment.
Because PHP's integer type is signed many crc32 checksums will result in negative integers on 32bit platforms.
Contributor
There was a problem hiding this comment.
I find it better to use sprintf('%u')
Contributor
Author
|
Tests are green 🎉 |
Member
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 4, 2022
…yweb) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Fix log channel of TagAwareAdapter | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Forgot to add the tag in #40740, therefore the "app" logger is injected instead of the "cache" one. Commits ------- 494ceaf [FrameworkBundle] Fix log channel of TagAwareAdapter
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Feb 4, 2022
…yweb) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Fix log channel of TagAwareAdapter | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Forgot to add the tag in symfony/symfony#40740, therefore the "app" logger is injected instead of the "cache" one. Commits ------- 494ceaf6cc [FrameworkBundle] Fix log channel of TagAwareAdapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.