Skip to content

[Cache] skip storing failure-to-save as misses in ArrayAdapter #40655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Nyholm merged 1 commit into from
Mar 31, 2021
Merged

[Cache] skip storing failure-to-save as misses in ArrayAdapter #40655

Nyholm merged 1 commit into from
Mar 31, 2021

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Mar 31, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #38694
License MIT
Doc PR -

In addition to #40645

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Mar 31, 2021
Nyholm
Nyholm approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit 2ceb35a into symfony:4.4 Mar 31, 2021
@nicolas-grekas nicolas-grekas deleted the cache-skip-fail branch April 12, 2021 15:40
This was referenced May 1, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jderusse jderusse jderusse approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees

No one assigned

Labels

Bug Cache Status: Reviewed

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolas-grekas @jderusse @Nyholm @carsonbot