[HttpKernel] Add #[AsController] attribute for declaring standalone controllers on PHP 8
#40555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
changed the title
#[AsController] attribute for declaring listeners on PHP 8#[AsController] attribute for declaring controllers on PHP 8
nicolas-grekas
changed the title
#[AsController] attribute for declaring controllers on PHP 8#[AsController] attribute for declaring standalone controllers on PHP 8
derrabus
approved these changes
Mar 23, 2021
Member
|
I think the renaming of other attributes at least deserves being in its own commit rather than being bundled in a commit saying |
yceruto
approved these changes
Mar 23, 2021
Member
yceruto
left a comment
yceruto
left a comment
There was a problem hiding this comment.
I really like the As prefix for all attributes, it offers us consistency and as you said better IDE autocompletion.
Member
|
@yceruto for all autoconfiguration attributes, I agree. I would not describe that as |
Member
Author
weaverryan
approved these changes
Mar 23, 2021
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
I like the As prefix also 👍
Member
@stof my bad, but that's what I meant 😄 ! |
chalasr
approved these changes
Mar 23, 2021
Member
|
Thank you @nicolas-grekas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
#[AsController]attribute to allow autoconfiguring controllers even when they don't extendAbstractController. This should allow removing the line aboutcontroller.service_argumentsinservices.yamlto cover this need (but that is noise to most.)