[Routing] force stringable object to string in route parameter #40342
Conversation
carsonbot
changed the title
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Nice!
Sorry if Fabbot suggested a bunch of CS changes. :/
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Thank you.
Im happy with this after two small changes.
src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Tobias Nyholm <tobias.nyholm@gmail.com>
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Thank you.
Im happy with this.
| if (!\is_object($param)) { | ||
| continue; | ||
| } | ||
| if (!\is_callable([$param, '__toString'])) { |
There was a problem hiding this comment.
I think a future PR can deal with if you pass an array or callable.
Or we may think that is not needed.
|
Oh, Fabbot saw that you missed something when adding the sprintf. :) |
|
I think I agree with @linaori's comments in the related issue, so mostly 👎 |
|
I forgot to mention that we tried to remove such string casts in the past from the framework. IIRC, @Tobion was quite vocal about this. |
|
Closing as 2 core team members voted against this change. |
6 participants
This is a simple proposal to fix related issue.