Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Travis CI 7.2 and 8.0 OK, i don't understand why 7.4 failed ;)

Thanks in advance for review ;)

Hi!

I think we should make this more generic and instead add a $requestParameters argument that allows passing any arbitrary request parameter. This would be helpful to e.g. configure _target_path to be redirected to (or anything else you want).

Btw, this interface is still experimental, so I think we can allow this BC break by adding a new argument. This should however be documented as such in the CHANGELOG.md file in src/Symfony/Component/Security (and in UPGRADE-5.3.md in the root of the project).

Do you agree & are you able to make these changes in this PR? :)

status: needs work

Hi!

I think we should make this more generic and instead add a $requestParameters argument that allows passing any arbitrary request parameter. This would be helpful to e.g. configure _target_path to be redirected to (or anything else you want).

Btw, this interface is still experimental, so I think we can allow this BC break by adding a new argument. This should however be documented as such in the CHANGELOG.md file in src/Symfony/Component/Security (and in UPGRADE-5.3.md in the root of the project).

Do you agree & are you able to make these changes in this PR? :)

status: needs work

@wouterj : If @fabpot and others core members are ok with your proposal, i'm ok to make changes in this PR.

I would prefer Request $request = null over an arbitrary array here.
👍 for changing the interface with a changelog entry, that's what @experimental is for.

I agree with Robin 👌🏻

@roromix To fix the tests, you must update the SecurityBundle composer.json to require symfony/security-http 5.3 as a minimum.

@roromix To fix the tests, you must update the SecurityBundle composer.json to require symfony/security-http 5.3 as a minimum.

@fabpot Thanks for your help. I will update this asap.

@roromix To fix the tests, you must update the SecurityBundle composer.json to require symfony/security-http 5.3 as a minimum.

Sorry @fabpot , but 5.3 is already as a minimum :
"symfony/security-http": "^5.3"

Maybe i haven't understand your message.

Perfect then (tests will be fixed after merging).

Thank you @roromix.

FYI, I added a conflict with symfony/security-bundle < 5.3, see 314ef9f

Sorry @nicolas-grekas , i need to correct the feature with new PR#40638