[SecurityBundle] Fix referencing aliases from RegisterEntryPointsPass #39982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
entrypoint-pass
branch
from
c99b2d0 to
8dcc3d6
Compare
chalasr
changed the title
nicolas-grekas
approved these changes
Jan 26, 2021
Member
|
Thank you @chalasr. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving child definitions' classes in this pass unlocks registering it as
TYPE_BEFORE_OPTIMIZATION, and get rid of the issue reported in #39881.The parent class resolution logic was borrowed from an existing pass (RegisterEventListenersAndSubscribersPass), that makes it the best solution I can think of.