[Uid] Add fromBase58(), fromBase32(), fromRfc4122() and fromBinary() methods #39850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
force-pushed
the
uid-from-format
branch
from
e071979 to
6753afb
Compare
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
Thanks for starting this.
fancyweb
force-pushed
the
uid-from-format
branch
from
6753afb to
2b48090
Compare
nicolas-grekas
force-pushed
the
uid-from-format
branch
from
2b48090 to
3b18f90
Compare
nicolas-grekas
force-pushed
the
uid-from-format
branch
from
3b18f90 to
c01ec7d
Compare
nicolas-grekas
approved these changes
Jan 20, 2021
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
(I updated the implementation to rely on a generic logic)
jderusse
approved these changes
Jan 20, 2021
Member
|
Thank you @fancyweb. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.