[Messenger] Add rediss:// DSN scheme support for TLS to Redis transport
#39607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
reviewed
Dec 22, 2020
Member
jderusse
left a comment
jderusse
left a comment
There was a problem hiding this comment.
As said in #39599 (comment) we should not support 2 ways to define the same thing (?tls=true vs rediss://)
This could lead to inconsistency like rediss://localhost?tls=false ?
Contributor
Author
|
I agree. Lets see first which should be considered a "primary" one, so that the other one can be deprecated/removed. However, both |
misaert
reviewed
Dec 24, 2020
src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
Outdated
Show resolved
Hide resolved
njutn95
force-pushed
the
feature/messenger-redis-tls
branch
from
592d0fd to
464f747
Compare
misaert
reviewed
Dec 24, 2020
njutn95
changed the title
rediss:// schemerediss:// DSN scheme support for TLS to Redis transport
OskarStark
reviewed
Jan 30, 2021
OskarStark
approved these changes
Feb 1, 2021
Contributor
|
Can you please rebase to get rid of the conflicts? Thanks |
njutn95
force-pushed
the
feature/messenger-redis-tls
branch
from
c7508fe to
3f19c28
Compare
Contributor
Author
|
@OskarStark Done |
maxhelias
approved these changes
Feb 17, 2021
src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
Outdated
Show resolved
Hide resolved
njutn95
force-pushed
the
feature/messenger-redis-tls
branch
from
3f19c28 to
89c4308
Compare
nicolas-grekas
force-pushed
the
feature/messenger-redis-tls
branch
from
dd83644 to
28e7b74
Compare
Member
|
Thank you @njutn95. |
Merged
This was referenced Sep 8, 2021
nicolas-grekas
added a commit
that referenced
this pull request
Sep 8, 2021
…cky) This PR was submitted for the 5.4 branch but it was squashed and merged into the 5.3 branch instead. Discussion ---------- [Messenger] Support rediss in transport bridge | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | Seems like support for `rediss` was added in the [main package](https://github.com/symfony/symfony/blob/e34cd7dd2c6d0b30d24cad443b8f964daa841d71/src/Symfony/Component/Messenger/Transport/TransportFactory.php#L46), but didn't propagate to the bridge Followed a trail from here - #39607 Commits ------- edfad64 [Messenger] Support rediss in transport bridge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a support for
rediss://DSN (as discussed in #39599) and deprecates the use oftlsparameter introduced in #35503 so it can be standardized to single format.