[Security] Add RememberMe Badge to LoginLinkAuthenticator #39584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
approved these changes
Dec 20, 2020
Member
wouterj
left a comment
wouterj
left a comment
There was a problem hiding this comment.
👍 This still keeps all control by the user (as remember me needs to be explicitly enabled on the firewall), but I see no reason not to allow login links to support remembered (if someone decides that for their application).
I think this can be merged as bugfix in 5.2? (given that this class is experimental, login link is extremely new and it doesn't change any behavior unless a user explicitly enabled remember me)
jderusse
changed the title
carsonbot
changed the title
OskarStark
approved these changes
Dec 21, 2020
jderusse
force-pushed
the
security-rememberme
branch
from
d47ae9a to
d38fc4d
Compare
Member
Author
|
rebased |
weaverryan
approved these changes
Dec 22, 2020
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
👍 That's a bug - good catch!
Member
|
Thank you Jérémy. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm replacing a custom home-made magic link authenticator by the Symfony one, and I missed this behavior. I had to use a EventListener to add the badge to the passeport.
I'm not sure, if the badge were missing on purpose /cc @weaverryan @wouterj