[Notifier] Use mb_strlen() to check the length limit #39575
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Dec 19, 2020
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 5.x |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
OskarStark
approved these changes
Dec 19, 2020
Member
|
This should apply on |
Member
Author
yes, in 5.2 with #39576 |
jderusse
reviewed
Dec 19, 2020
| public function __construct(string $text) | ||
| { | ||
| if (\strlen($text) > self::TEXT_LIMIT) { | ||
| if (mb_strlen($text, 'UTF-8') > self::TEXT_LIMIT) { |
Member
There was a problem hiding this comment.
I thought slack counts in bytes => https://github.com/symfony/symfony/pull/39410/files#r539845790
Member
Author
thanks for the link, I missed this reply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.