Skip to content

[Notifier] [BC BREAK] Final classes #39557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chalasr merged 1 commit into from
Dec 30, 2020
Merged

[Notifier] [BC BREAK] Final classes #39557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Symfony/Component/Notifier/Bridge/LinkedIn/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ CHANGELOG
-----

* The bridge is not marked as `@experimental` anymore
* [BC BREAK] `LinkedInTransportFactory` is now final
Copy link
Member

@jderusse jderusse Dec 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be reported in UPGRADE-5.3.md?


5.2.0
-----
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Notifier/Bridge/LinkedIn/LinkedInTransportFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
/**
* @author Smaïne Milianni <smaine.milianni@gmail.com>
*/
class LinkedInTransportFactory extends AbstractTransportFactory
final class LinkedInTransportFactory extends AbstractTransportFactory
{
public function create(Dsn $dsn): TransportInterface
{
Expand Down
7 changes: 7 additions & 0 deletions src/Symfony/Component/Notifier/Bridge/Smsapi/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
CHANGELOG
=========

5.3.0
-----

* Added the bridge
2 changes: 2 additions & 0 deletions src/Symfony/Component/Notifier/Bridge/Smsapi/SmsapiTransport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@

/**
* @author Marcin Szepczynski <szepczynski@gmail.com>
*
* @experimental in 5.3
*/
final class SmsapiTransport extends AbstractTransport
{
Expand Down
4 changes: 3 additions & 1 deletion src/Symfony/Component/Notifier/Bridge/Smsapi/SmsapiTransportFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@

/**
* @author Marcin Szepczynski <szepczynski@gmail.com>
*
* @experimental in 5.3
*/
class SmsapiTransportFactory extends AbstractTransportFactory
final class SmsapiTransportFactory extends AbstractTransportFactory
{
/**
* @return SmsapiTransport
Expand Down
2 changes: 2 additions & 0 deletions src/Symfony/Component/Notifier/Bridge/Zulip/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ CHANGELOG
-----

* The bridge is not marked as `@experimental` anymore
* [BC BREAK] `ZulipTransport` is now final
* [BC BREAK] `ZulipTransportFactory` is now final
Copy link
Member

@jderusse jderusse Dec 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same


5.2.0
-----
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Notifier/Bridge/Zulip/ZulipTransport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
/**
* @author Mohammad Emran Hasan <phpfour@gmail.com>
*/
class ZulipTransport extends AbstractTransport
final class ZulipTransport extends AbstractTransport
{
private $email;
private $token;
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Notifier/Bridge/Zulip/ZulipTransportFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
/**
* @author Mohammad Emran Hasan <phpfour@gmail.com>
*/
class ZulipTransportFactory extends AbstractTransportFactory
final class ZulipTransportFactory extends AbstractTransportFactory
{
/**
* @return ZulipTransport
Expand Down