Skip to content

[Notifier] [Discord] Use private const and mb_strlen() #39492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabpot merged 1 commit into from
Dec 17, 2020
Merged

[Notifier] [Discord] Use private const and mb_strlen() #39492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Symfony/Component/Notifier/Bridge/Discord/DiscordTransport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ final class DiscordTransport extends AbstractTransport
{
protected const HOST = 'discord.com';

private const SUBJECT_LIMIT = 2000;

private $token;
private $webhookId;

Expand Down Expand Up @@ -65,7 +67,7 @@ protected function doSend(MessageInterface $message): SentMessage

$content = $message->getSubject();

if (\strlen($content) > 2000) {
if (mb_strlen($content, 'UTF-8') > self::SUBJECT_LIMIT) {
throw new LogicException('The subject length of a Discord message must not exceed 2000 characters.');
}

Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Notifier/Bridge/Discord/Tests/DiscordTransportTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public function testSendChatMessageWithMoreThan2000CharsThrowsLogicException()
$this->expectException(LogicException::class);
$this->expectExceptionMessage('The subject length of a Discord message must not exceed 2000 characters.');

$transport->send(new ChatMessage(str_repeat('d', 2001)));
$transport->send(new ChatMessage(str_repeat('囍', 2001)));
}

public function testSendWithErrorResponseThrows()
Expand Down