Skip to content

[String] Fix Notice when argument is empty string #39244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derrabus merged 1 commit into from
Dec 1, 2020
Merged

[String] Fix Notice when argument is empty string #39244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Symfony/Component/String/Inflector/EnglishInflector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@ final class EnglishInflector implements InflectorInterface
* A list of words which should not be inflected, reversed.
*/
private static $uninflected = [
'',
'atad',
'reed',
'kcabdeef',
Expand Down
12 changes: 12 additions & 0 deletions src/Symfony/Component/String/Tests/EnglishInflectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,4 +306,16 @@ public function testPluralize(string $singular, $plural)
{
$this->assertSame(\is_array($plural) ? $plural : [$plural], (new EnglishInflector())->pluralize($singular));
}

public function testPluralizeEmptyString()
{
$plural = (new EnglishInflector())->pluralize('');
$this->assertSame([''], $plural);
}

public function testSingularizeEmptyString()
{
$singular = (new EnglishInflector())->singularize('');
$this->assertSame([''], $singular);
}
}