Skip to content

[HttpClient] Check status code before decoding content in TraceableResponse #38977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Nov 3, 2020
Merged

[HttpClient] Check status code before decoding content in TraceableResponse #38977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/Symfony/Component/HttpClient/Response/TraceableResponse.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,24 +52,24 @@ public function getHeaders(bool $throw = true): array

public function getContent(bool $throw = true): string
{
$this->content = $this->response->getContent(false);

if ($throw) {
$this->checkStatusCode($this->response->getStatusCode());
try {
return $this->content = $this->response->getContent(false);
} finally {
if ($throw) {
$this->checkStatusCode($this->response->getStatusCode());
}
}

return $this->content;
}

public function toArray(bool $throw = true): array
{
$this->content = $this->response->toArray(false);

if ($throw) {
$this->checkStatusCode($this->response->getStatusCode());
try {
return $this->content = $this->response->toArray(false);
} finally {
if ($throw) {
$this->checkStatusCode($this->response->getStatusCode());
}
}

return $this->content;
}

public function cancel(): void
Expand Down
13 changes: 13 additions & 0 deletions src/Symfony/Component/HttpClient/Tests/TraceableHttpClientTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
use Symfony\Component\HttpClient\NativeHttpClient;
use Symfony\Component\HttpClient\Response\MockResponse;
use Symfony\Component\HttpClient\TraceableHttpClient;
use Symfony\Contracts\HttpClient\Exception\ClientExceptionInterface;
use Symfony\Contracts\HttpClient\HttpClientInterface;
use Symfony\Contracts\HttpClient\Test\TestHttpServer;

Expand Down Expand Up @@ -100,4 +101,16 @@ public function testStream()
$this->assertGreaterThan(1, \count($chunks));
$this->assertSame('Symfony is awesome!', implode('', $chunks));
}

public function testToArrayChecksStatusCodeBeforeDecoding()
{
$this->expectException(ClientExceptionInterface::class);

$sut = new TraceableHttpClient(new MockHttpClient($responseFactory = function (): MockResponse {
return new MockResponse('Errored.', ['http_code' => 400]);
}));

$response = $sut->request('GET', 'https://example.com/foo/bar');
$response->toArray();
}
}