[HttpFoundation] Deprecate not passing a Closure together with FILTER_CALLBACK to ParameterBag::filter()
#38859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
reviewed
Oct 28, 2020
nicolas-grekas
force-pushed
the
twig-no-callback
branch
from
2f38135 to
ef10cac
Compare
jderusse
approved these changes
Oct 28, 2020
Member
|
LGTM once a test has been added. 🙃 |
stof
approved these changes
Oct 28, 2020
chalasr
approved these changes
Oct 30, 2020
…TER_CALLBACK` to `ParameterBag::filter()`
nicolas-grekas
force-pushed
the
twig-no-callback
branch
from
ef10cac to
d6aea28
Compare
Member
Author
|
Test added |
derrabus
approved these changes
Oct 30, 2020
Member
|
Thank you Nicolas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
filter_var()with a configurable flag is risky, because of theFILTER_CALLBACKflag.Restricting the type of callable that is accepted here mitigates the risk.
We did the same in Twig: twigphp/Twig#3308