Skip to content

Conversation

@ocrampete16
Copy link
Contributor

@ocrampete16 ocrampete16 commented Oct 28, 2020

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #38766
License MIT

This PR adds missing form, security and validator translations for Tagalog.

I also skimmed over the existing translations and corrected spelling mistakes I could find.

@ocrampete16 ocrampete16 requested a review from xabbuh as a code owner October 28, 2020 07:24
@carsonbot carsonbot added this to the 3.4 milestone Oct 28, 2020
@ocrampete16 ocrampete16 changed the title Add missing translations for Tagalog (tl) #38766 Add missing translations for Tagalog (tl) Oct 28, 2020
@derrabus derrabus modified the milestones: 3.4, 4.4 Oct 28, 2020
@fabpot fabpot changed the base branch from 3.4 to 4.4 October 28, 2020 07:34
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this.

<trans-unit id="13">
<source>Account has expired.</source>
<target>Ang akawnt ay nag-expire na.</target>
<target>Ang account ay nag-expire na.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, is this the same as in English?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, for historical reasons Tagalog often doesn't have equivalents for a lot of the words used today. I've seen people "tagalogize" some words, like otel (hotel) or nars (nurse), but given the country's close ties to America, people just use English words in lieu of Tagalog ones and they're universally understood.

Actually, people often prefer to use English words even if a Tagalog equivalent exists. I would probably get strange looks in Manila for asking where the "aklatan" is instead of the "library". :D

@derrabus
Copy link
Member

Thank you Marco.

@derrabus derrabus merged commit 587ed0d into symfony:4.4 Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants