[HttpClient] Add a Stopwatch on TraceableHttpClient #38688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
force-pushed
the
hc-stopwatch
branch
from
a622a5a to
5ab338b
Compare
Nyholm
approved these changes
Oct 23, 2020
Member
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
This is an excellent idea. Thank you
| } | ||
|
|
||
| foreach ($client->stream($wrappedResponses, $timeout) as $r => $chunk) { | ||
| if ($traceableMap[$r]->event && $traceableMap[$r]->event->isStarted() && $chunk->isLast()) { |
Member
There was a problem hiding this comment.
calling isLast() without checking for getError will throw when an error happens (same for timeouts)
Member
Author
There was a problem hiding this comment.
Good catch.
I added lap on timeout and chunk (same for getStatus and getHeader) To show a "tick" when content is partially received.
$response1 = $client->request('GET', 'https://httpstat.us/200');
$response1->getContent(false);
$response2 = $client->request('GET', 'https://httpstat.us/404');
$response2->getContent(false);
$responses[] = $client->request('GET', 'https://httpstat.us/200?sleep=3000');
$responses[] = $client->request('GET', 'https://httpstat.us/200?sleep=500');
try {
foreach ($client->stream($responses, 1) as $chunk) {}
} catch (\Exception $e)
{}
sleep(1);
foreach ($responses as $response) {
$response->getContent();
}
jderusse
force-pushed
the
hc-stopwatch
branch
3 times, most recently
from
bcab52a to
5759497
Compare
stof
reviewed
Oct 23, 2020
src/Symfony/Component/HttpClient/Response/TraceableResponse.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpClient/Response/TraceableResponse.php
Outdated
Show resolved
Hide resolved
jderusse
force-pushed
the
hc-stopwatch
branch
2 times, most recently
from
a7f9109 to
ff928bc
Compare
jderusse
force-pushed
the
hc-stopwatch
branch
from
ff928bc to
e6f6b4c
Compare
nicolas-grekas
approved these changes
Oct 23, 2020
fabpot
approved these changes
Oct 23, 2020
Member
|
Thank you @jderusse. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this code to generate the screenshot below.