Skip to content

[HttpClient] never trace content of event-stream responses #38682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Nyholm merged 1 commit into from
Oct 22, 2020
Merged

[HttpClient] never trace content of event-stream responses #38682

Nyholm merged 1 commit into from
Oct 22, 2020

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Oct 22, 2020

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Let's leverage #38587 in EventSourceHttpClient

@nicolas-grekas nicolas-grekas added this to the 5.2 milestone Oct 22, 2020
@Nyholm
Copy link
Member

Nyholm commented Oct 22, 2020

Cool cool cool. Thank you

@Nyholm Nyholm merged commit 6f0a897 into symfony:5.x Oct 22, 2020
@nicolas-grekas nicolas-grekas deleted the hc-no-trace branch October 23, 2020 09:37
@fabpot fabpot mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jderusse jderusse jderusse approved these changes

@chalasr chalasr chalasr approved these changes

Assignees

No one assigned

Labels

Bug HttpClient Status: Reviewed

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas @Nyholm @jderusse @chalasr @carsonbot