Skip to content

[RateLimiter] Be more type safe when fetching from cache #38670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chalasr merged 1 commit into from
Oct 22, 2020
Merged

[RateLimiter] Be more type safe when fetching from cache #38670

chalasr merged 1 commit into from
Oct 22, 2020

Conversation

@Nyholm
Copy link
Member

@Nyholm Nyholm commented Oct 21, 2020

Q A
Branch? 5.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

This is a super minor thing. A $cacheItem can be a hit, but it does not contain a LimiterStateInterface.

Also, PSR-6 specifies that if the $cacheItem is not a hit, it must return null.

@Nyholm Nyholm changed the title [RateLimiter] Be more type safe when fetching form cache [RateLimiter] Be more type safe when fetching from cache Oct 22, 2020
@chalasr chalasr added this to the 5.2 milestone Oct 22, 2020
@chalasr
Copy link
Member

chalasr commented Oct 22, 2020

Thank you @Nyholm.

@chalasr chalasr merged commit 7539325 into symfony:5.x Oct 22, 2020
@Nyholm
Copy link
Member Author

Nyholm commented Oct 22, 2020

Thank you for reviews and merge.

@fabpot fabpot mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees

No one assigned

Labels

Bug RateLimiter Status: Reviewed

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

4 participants

@Nyholm @chalasr @nicolas-grekas @carsonbot