Skip to content

[DoctrineBridge] Enabled to use the UniqueEntity constraint as an attribute #38653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Oct 21, 2020
Merged

[DoctrineBridge] Enabled to use the UniqueEntity constraint as an attribute #38653

fabpot merged 1 commit into from
Oct 21, 2020

Conversation

@derrabus
Copy link
Member

@derrabus derrabus commented Oct 20, 2020

Q A
Branch? 5.2
Bug fix? no
New feature? yes
Deprecations? no
Tickets #38096
License MIT
Doc PR TODO with symfony/symfony-docs#14305

Now that we have a compatible Doctrine version, I could patch and test the missing UniqueEntity constraint.

@derrabus derrabus force-pushed the improvement/uniqe-entity-attribute branch from 1689c2c to 83d9f23 Compare October 20, 2020 23:13
@derrabus
Copy link
Member Author

derrabus commented Oct 20, 2020

Note: I'll remove the second commit from this PR as soon as #38648 is merged.

@derrabus derrabus force-pushed the improvement/uniqe-entity-attribute branch from 83d9f23 to b4691be Compare October 20, 2020 23:16
@fabpot
Copy link
Member

fabpot commented Oct 21, 2020

@derrabus Referenced PR is merged now.

@derrabus derrabus force-pushed the improvement/uniqe-entity-attribute branch from b4691be to 5e7d3ab Compare October 21, 2020 08:47
@derrabus
Copy link
Member Author

derrabus commented Oct 21, 2020

Thanks, PR is rebased.

jderusse
jderusse reviewed Oct 21, 2020
View reviewed changes
@fabpot
Copy link
Member

fabpot commented Oct 21, 2020

Thank you @derrabus.

@fabpot fabpot merged commit 35dad22 into symfony:5.x Oct 21, 2020
@derrabus derrabus deleted the improvement/uniqe-entity-attribute branch October 21, 2020 10:02
@fabpot fabpot mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@jderusse jderusse jderusse approved these changes

Assignees

No one assigned

Labels

DoctrineBridge Feature Status: Reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@derrabus @fabpot @jderusse @carsonbot