Skip to content

[HttpFoundation][RateLimiter] fix RequestRateLimiterInterface::reset() #38623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
derrabus merged 1 commit into from
Oct 18, 2020
Merged

[HttpFoundation][RateLimiter] fix RequestRateLimiterInterface::reset() #38623

derrabus merged 1 commit into from
Oct 18, 2020
+2 −2

Conversation

@kbond
Copy link
Member

@kbond kbond commented Oct 18, 2020 •
edited
Loading

Q A
Branch? 5.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

The reset method requires the $request.

@derrabus derrabus requested a review from wouterj October 18, 2020 22:25
@derrabus derrabus added this to the 5.2 milestone Oct 18, 2020
wouterj
wouterj approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks

@derrabus
Copy link
Member

derrabus commented Oct 18, 2020

Thank you @kbond.

@derrabus derrabus merged commit 2702d81 into symfony:5.x Oct 18, 2020
@kbond kbond deleted the request-rate-limiter-fix branch October 18, 2020 22:36
@fabpot fabpot mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wouterj wouterj wouterj approved these changes

@derrabus derrabus derrabus approved these changes

Assignees

No one assigned

Labels

Bug HttpFoundation Status: Reviewed

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

4 participants

@kbond @derrabus @wouterj @carsonbot