Skip to content

[Console] Fix signal management #38602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lyrixx merged 1 commit into from
Oct 16, 2020
Merged

[Console] Fix signal management #38602

lyrixx merged 1 commit into from
Oct 16, 2020

Conversation

@chalasr
Copy link
Member

@chalasr chalasr commented Oct 16, 2020 •
edited
Loading

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Missed in #38589

@chalasr chalasr added this to the 5.2 milestone Oct 16, 2020
@chalasr chalasr mentioned this pull request Oct 16, 2020
Merged
@lyrixx
Copy link
Member

lyrixx commented Oct 16, 2020 •
edited
Loading

There were other issues

symfony/src/Symfony/Component/Console/Application.php

Line 289 in cbfa540

$this->signalRegistry->register($signal, function ($signal, $hasNext) use ($event) {

symfony/src/Symfony/Component/Console/Application.php

Line 961 in cbfa540

$this->signalRegistry->register($signal, [$command, 'handleSignal']);

And this check is wrong too. I mean the error message does not reflect what is going.

symfony/src/Symfony/Component/Console/Application.php

Lines 957 to 958 in cbfa540

if (!$this->signalsToDispatchEvent) {
throw new RuntimeException('Unable to subscribe to signal events. Make sure that the `pcntl` extension is installed and that "pcntl_*" functions are not disabled by your php.ini\'s "disable_functions" directive.');

lyrixx
lyrixx reviewed Oct 16, 2020
View reviewed changes
lyrixx
lyrixx approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼
Thank you Robin for taking time of fixing this :)
I'm gonna change the title of your PR to get a "nice" git history

@lyrixx lyrixx changed the title [Console] Fix Application::getSignalRegistry() retval [Console] Fix signal management Oct 16, 2020
@chalasr
Copy link
Member Author

chalasr commented Oct 16, 2020

I'm gonna change the title of your PR to get a "nice" git history

Broader, but not wrong :) Thanks!

@lyrixx
Copy link
Member

lyrixx commented Oct 16, 2020

You were fast on this one, thanks Robin.

@lyrixx lyrixx merged commit 6088728 into symfony:5.x Oct 16, 2020
@fabpot fabpot mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyrixx lyrixx lyrixx approved these changes

Assignees

No one assigned

Labels

Bug Console Status: Reviewed

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

3 participants

@chalasr @lyrixx @carsonbot