[HttpClient] added extra.trace_content option to TraceableHttpClient to prevent it from keeping the content in memory
#38587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt` to prevent it from keeping the content in memory
Member
|
should we have an option in the TraceableHttpClient constructor to control the default value rather than harcoding it to |
Member
Author
|
We could have an option in the constructor, and a corresponding config option. |
jderusse
approved these changes
Oct 15, 2020
fabpot
approved these changes
Oct 16, 2020
Member
|
Thank you @nicolas-grekas. |
Nyholm
added a commit
that referenced
this pull request
Oct 22, 2020
… (nicolas-grekas) This PR was merged into the 5.x branch. Discussion ---------- [HttpClient] never trace content of event-stream responses | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Let's leverage #38587 in `EventSourceHttpClient` Commits ------- e4c0262 [HttpClient] never trace content of event-stream responses
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TraceableHttpClientleaks memory by definition. But sometimes, this leak is to important, especially when keeping the response content in memory.This PR adds a new
trace_contentoption underextraso that consumers can tell the client to not trace the content. This will be ignored whenTraceableHttpClientis not in use.