[Mailer] Add MessageSentEvent
#38519
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The current implementation will only dispatch this notification when we are not using a MessageBus. It will also not dispatch an event when we are using the transport directly. Ie, it makes it hard for a listener to know if it sees all events or not. But didn't we solve the problem in #38517? Or is this a new scenario? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the transport
This would be an alternative way to access the
SentMessageafter the message has been sent through a transport. More general than #38517, but the DX might be worse because it takes you of of the current program flow.But also nicer because it always works the same way, with messenger and without.