Change ExceptionListenerPass removeDefinition args #38483
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the test class so it covers the initial behavior on 4.4.14, prior to the 4.4.15 release.
According the the previous commit; in order to keep it consistent with 4.4.14 version.
Author
|
So I basically reverted 4.4.15 and I kept the test file. I then add a test in order to cover the 4.4.14 version current behavior. Obviously, applying the 4.4.15 changes made my test failed. The question is:
Curious to know what you guys think about all that. |
nicolas-grekas
requested changes
Oct 12, 2020
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
/cc @dmolineus for thoughts since @adaniloff apparently disagrees with you.
src/Symfony/Bundle/TwigBundle/DependencyInjection/Compiler/ExceptionListenerPass.php
Show resolved
Hide resolved
src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/Compiler/ExceptionListenerPassTest.php
Show resolved
Hide resolved
Author
|
Closing since it is related to FOSUser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the 4.4.15 upgrade, our FOSRest (2.6) configuration did not work anymore.
See the issue in #38482 for more explanation.