[DI] Fix "!tagged" related re-allow #38438
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Why this PR? If we can deprecate this earlier, it's better IMHO. The other formats are separate. If for consistency, we might need a stronger argument IMHO. |
Contributor
Author
|
Ok that's fine, it was to harmonize the different formats. |
Contributor
Author
|
@nicolas-grekas For other formats, can we re-introduce the deprecation of the "tagged" in 5.x? |
Member
|
nope, #34170 tells why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #34170 and the continuation of #34180
Are we re-introducing deprecatoin in 5.x?