[Console] Make sure $maxAttempts is an int or null #38080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Sep 7, 2020
fabpot
approved these changes
Sep 7, 2020
fabpot
approved these changes
Sep 7, 2020
fabpot
requested review from
dunglas,
lyrixx,
sroze and
xabbuh
as code owners
fabpot
force-pushed
the
bugfix/max-attempts-int
branch
from
b81e280 to
4fcd491
Compare
Member
|
Thank you @derrabus. |
This was referenced Sep 27, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of the "less than" operator for mixed types has changed in php 8. It is now possible to call
setMaxAttempts()with a random string without raising the expectedInvalidArgumentException. I've added an explicit type cast in order to restore the previous behavior.