[Yaml Parser] fixed Parser to skip comments when inlining sequences #38040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
Thanks for having a look and submitting.
src/Symfony/Component/DependencyInjection/Tests/Fixtures/yaml/services9.yml
Outdated
Show resolved
Hide resolved
xabbuh
reviewed
Sep 3, 2020
| ]] | ||
| YAML | ||
| ], | ||
| 'with-comments-trailing-comma' => [ |
Member
There was a problem hiding this comment.
I fail to see how this test case differs from the previous one.
Contributor
Author
There was a problem hiding this comment.
Oops you're right. The 'with-comments' was meant to be without a comma after the 2nd array element. I've fixed it.
xabbuh
approved these changes
Sep 6, 2020
Member
|
Thank you @korve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser didn't skip comments when parsing values in a sequence. This resulted in the YamlFileLoader trying to
parse a comment as a IteratorArgument which resulted in a InvalidArgumentException.
Consider the following valid yaml:
The parser would generate the following array:
After this fix the parser will generate the following array:
['bar']This bug only appeared for me in 4.4