[Security] Fixed RememberMeAuthenticator::autoLogin() logic in the authenticator #37943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
force-pushed
the
issue-37534/rememberme-getuser
branch
from
fb2c12d to
93aea91
Compare
Contributor
|
I have tested #37943 against my replication steps in #37534 and it resulted in a graceful failure as expected. 🎉🎉 Thanks for this @wouterj |
fabpot
approved these changes
Aug 25, 2020
Member
|
Thank you @wouterj. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RememberMeAuthenticatorwrongly assumed the implementation details ofAbstractRememberMeServices::autoLogin(). This means that (a) the authenticator did not work with other - custom - implementations ofRememberMeServicesInterfaceand (b) there was a potentional to get an "Call to a member function getUser() on null" error.This code removes all assumptions of the
autoLogin()logic, other than that stated in the PHPdoc:symfony/src/Symfony/Component/Security/Http/RememberMe/RememberMeServicesInterface.php
Lines 43 to 53 in 32ca714